-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HADOOP-19559. Updates S3A default stream to AAL. #8095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@steveloughran PR to update the default stream to AAL. there are some tests assert on behaviours of the classic input stream, and so those have been updated to always used Classic. |
|
also working on updating: #7923 and then we're done |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. pending those test failures; all look just test being fussy about expected values
|
I don't think we should try and fixing these tests, instead always run them with the classic input stream. Most of them assert behaviour which does not apply to AAL (eg: the readAhead value, stream draining, or thread context stats). What I will do as a follow up is look at which ones make sense to have as part of a new ITest for AAL. Similar to what we did for the prefetching input stream. I will make those changes as part of our #7923. Merging this for now and will backport, so if you kick of a 3.4.3 run this weekend we can catch any issues early. |
Description of PR
Updates S3A's default stream to use AAL.
How was this patch tested?
In progress
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?