-
Notifications
You must be signed in to change notification settings - Fork 9.2k
YARN-11876. Fix AsyncDispatcher crash in TestAppManager #8014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
33510fe to
4ad6019
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
e4dadc1 to
ade7557
Compare
Fix-Rm-Unit-Crash.
aea6da2 to
e934ce3
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
@cnauroth @steveloughran @szetszwo Could you please help review this PR? Thank you very much! This PR fixes an issue that caused the YARN ResourceManager to crash during JUnit tests. |
szetszwo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 the change looks good.
|
@szetszwo Thank you very much for helping review the code! |
Description of PR
JIRA: YARN-11876. Fix AsyncDispatcher crash in TestAppManager.
After upgrading to
JUnit 5, theResourceManagermodule encounters a crash when running unit tests. Specifically, the failure occurs in the test caseTestAppManager#testRMAppSubmitWithQueueChanged.During application submission, the test changes the queue assignment, which triggers a
SchedulerEventthat the AsyncDispatcher cannot handle.As a result, the dispatcher thread throws an exception and terminates, causing the test JVM to exit abnormally with a
SurefireBooterForkException.This leads to Maven Surefire reporting a forked VM crash:
How was this patch tested?
CI.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?