HDDS-1451 : SCMBlockManager findPipeline and createPipeline are not lock protected. #799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
/label ozone |
Contributor
Author
|
/retest |
mukul1987
requested changes
May 17, 2019
Contributor
mukul1987
left a comment
mukul1987
left a comment
There was a problem hiding this comment.
The patch looks good to me. Please change the log lines to add the type and factor.
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/BlockManagerImpl.java
Outdated
Show resolved
Hide resolved
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/BlockManagerImpl.java
Outdated
Show resolved
Hide resolved
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
@avijayanhwx the patch looks good to me. Can you please confirm that the test failures are not due to this patch. Thanks in Advance. |
Contributor
Author
@anuengineer The failures seem unrelated. I have rebased with latest trunk. We can see how this run goes and then commit it. |
Contributor
|
+1, LGTM. Thanks. |
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
As per subject, table descriptors moved are - LocalTableDescriptor - RemoteTableDescriptor - HybridTableDescriptor - GuavaCacheTableDescriptor - CachingTableDescriptor Author: Wei Song <[email protected]> Reviewers: Prateek Maheshwari <[email protected]> Closes apache#799 from weisong44/SAMZA-1981
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The getPipelines() and createPipeline() already seem to have a lock in their implementation. However, the problem described here involves a race condition between the call to getPipelines and createPipelines in BlockManagerImpl#allocateBlock. The fix is to add another getPipelines check after a failed createPipeline call to get any newly created pipelines.