HADOOP-16294: Enable access to input options by DistCp subclasses #796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
| } | ||
|
|
||
| /** | ||
| * Returns the input options |
Contributor
There was a problem hiding this comment.
needs a "." at the end or javadoc is unhappy
Contributor
|
-1, compile failing |
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
Fixed ( noslowerdna@0301c83 ), I didn't realize that the trunk code had changed from the version I'd been working with. We would want subclasses to have access to the |
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
yetus isn't reviewing this again, is it? |
Contributor
|
...even if yetus is silent, patch LGTM. @noslowerdna once you are happy with these changes are working for what you are doing with distcp, I'm happy to merge it in |
Contributor
Author
|
Thank you @steveloughran - I'm happy with this patch. |
Contributor
|
+1 committed to branch-3.2+, can go earlier if you want |
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
This PR makes the following changes * Enriches StreamPartitionCountMonitor to periodically monitor input-regexes to match to actual inputs and stop the job when a new input stream is discovered. * Add a new API to SysAdmin to allow listing of all streams, e.g., Kafka-topics. KafkaSysAdmin implementation of this uses KafkaConsumer's listTopics API. (Even if listTopics had 1 million topics with 100 bytes per topic total, temporary memory overhead will be 100 MB). * Added config job.coordinator.monitor-input-regex.frequency.ms for the monitoring frequency, and job.coordinator.monitor-input-regex.%s for each input system. Users can then choose desired regex for each input system, e.g., job.coordinator.monitor-input-regex.kafka=test-.*. * We can later enrich RegexTopicGen rewriter to add a monitor-input-regex config to allow periodic jonitoring * Tested: Unit test for SPCM and tested with test jobs on local grid. Author: Ray Matharu <[email protected]> Reviewers: Jagadish<[email protected]> Closes apache#796 from rmatharu/newtopic-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HADOOP-16294
Adding a protected-scope getter for the DistCpOptions, so that a subclass does not need to save its own copy of the inputOptions supplied to its constructor, if it wishes to override the createInputFileListing method with logic similar to the original implementation, i.e. calling CopyListing#buildListing with a path and input options.