HDFS-17783. [ARR] Optimize the debug log of method asyncIpcClient to print concrete call info. #7686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…print concrete call info.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
Hi, @slfan1989 @Hexiaoqiao @KeeProMise . Could you please help review this simple modification when you are free? Thanks a lot! |
Member
|
Hi @hfutatzhanghb LGTM! cc @slfan1989 @Hexiaoqiao |
KeeProMise
approved these changes
May 23, 2025
Member
|
Hi @hfutatzhanghb LGTM! Let's wait for two days to see if anyone else has comments. |
slfan1989
reviewed
May 26, 2025
| * that the task execution reflects the state of the original calling thread. | ||
| */ | ||
| public void transfer() { | ||
| Server.getCurCall().set(null); |
Contributor
There was a problem hiding this comment.
@hfutatzhanghb Thanks for the contribution! Why do we set it to null?
Contributor
Author
There was a problem hiding this comment.
@slfan1989 Thanks a lot for your reviewing, we should reset Server.getCurCall here to avoid async responder thread use wrong ThreadLocal variable. For example, router always receives safemode_get response from NameNode, if we don't reset Server.getCurCall(), we will find the call information occurs in the debug log which is not accurate.
Contributor
Author
There was a problem hiding this comment.
Here is a screenshot which can better explain this case.
Hexiaoqiao
approved these changes
May 27, 2025
Contributor
Hexiaoqiao
left a comment
Hexiaoqiao
left a comment
There was a problem hiding this comment.
LGTM. +1 from my side.
Member
|
hi @slfan1989 Do you have more comments? |
Member
|
@hfutatzhanghb thanks for your contributions, @Hexiaoqiao @slfan1989 thanks for your review, merged |
Contributor
Author
|
Thanks @KeeProMise for merging. Thanks all for help reviewing！ |
YanivKunda
pushed a commit
to YanivKunda/hadoop
that referenced
this pull request
Jul 7, 2025
…print concrete call info. (apache#7686). Contributed by hfutatzhanghb. Reviewed-by: He Xiaoqiao <[email protected]> Reviewed-by: Shilun Fan <[email protected]> Signed-off-by: Jian Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Refer to HDFS-17783.
Currently, the debug log in method asyncIpcClient can not print the RpcCall information such as callId. clientIp, clientPort, callercontext. etc.
It print lambda expression object now which is not what we expected.