HDDS-999. Make the DNS resolution in OzoneManager more resilient. (swagle) #758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
bharatviswa504
requested changes
Apr 23, 2019
Contributor
bharatviswa504
left a comment
bharatviswa504
left a comment
There was a problem hiding this comment.
I have a few comments, rest LGTM.
Contributor
There was a problem hiding this comment.
We removed WAITFOR env usage, there are few other files where this is used, om-statefulset.yaml. Do we need to remove from there also?
And also we are removing usage of WAITFOR, then do we need to remove the logic for this in docker image code?
Contributor
Author
There was a problem hiding this comment.
Making the changes to remove the wait for, @elek it makes sense to remove the wait for from everywhere, right?
|
💔 -1 overall
This message was automatically generated. |
elek
reviewed
Apr 25, 2019
Member
There was a problem hiding this comment.
ENSURE_OM_INITIALIZED is not required here. For kubernetes we follow a different (more generic) approach. We can define an 'initContainer' to execute the 'om --init' first. (as you can see this is the initContainer here). As the 'om --init' can be executed multiple times it works well without the environment variable (which is handled by the starter script of the container.
Contributor
Author
There was a problem hiding this comment.
Thanks for the review @elek. Removed in the latest commit.
|
💔 -1 overall
This message was automatically generated. |
elek
approved these changes
Apr 26, 2019
Member
elek
left a comment
elek
left a comment
There was a problem hiding this comment.
+1. Thanks the update. Will merge it soon...
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
Author: [email protected] <[email protected]> Reviewers: Prateek Maheshwari <[email protected]> Closes apache#758 from rmatharu/doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brought back change from HDDS-776 with the retriable task, OM will now wait for at least 50 seconds before giving up.