-
Notifications
You must be signed in to change notification settings - Fork 9k
HADOOP-19310. Add JPMS options required by Java 17+ #7114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGTM |
💔 -1 overall
This message was automatically generated. |
slfan1989
approved these changes
Oct 12, 2024
@adoroszlai Can you help review this PR? Thank you very much! |
adoroszlai
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thansk @pan3793 for the patch, LGTM.
@pan3793 Thanks for the contribution! @adoroszlai Thanks for the review! @pan3793 Could you help submit a PR for branch-3.4? |
pan3793
added a commit
to pan3793/hadoop
that referenced
this pull request
Oct 16, 2024
…tributed by Cheng Pan. Reviewed-by: Attila Doroszlai <[email protected]> Signed-off-by: Shilun Fan <[email protected]>
slfan1989
pushed a commit
that referenced
this pull request
Oct 17, 2024
) * HADOOP-19310. Add JPMS options required by Java 17+ (#7114) Contributed by Cheng Pan. Reviewed-by: Attila Doroszlai <[email protected]> Signed-off-by: Shilun Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HADOOP-19310. Add JPMS options required by Java 17+
Description of PR
This PR adds JPMS args to both maven surefire plugin and
hadoop-functions.sh
, to fix issues like the below that happen with JDK 17+, for all of the modules in the Hadoop project.This is the next step of HADOOP-19219, which fixes the JPMS issues for
hadoop-common
.How was this patch tested?
Test environment: x86 Ubuntu 22.04, Zulu JDK 17.0.8, Maven 3.9.8
Run all tests except for
hadoop-yarn-server-timelineservice-hbase-tests
-surefire runs in non-fork mode thus JPMS args do not take effect.The whole UT takes around 18-24 hours to finish, for developers who want to contribute to Java 17 support, please focus on the exclude-tests.txt, and I will update the list timely.
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?