HDDS-1254. Fix failure in TestOzoneManagerHttpServer & TestStorageCon… #598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoyuyao
reviewed
Mar 12, 2019
Contributor
There was a problem hiding this comment.
Should the last assert in line 113-114 be changed to for http?
Assert.assertTrue(implies(policy.isHttpEnabled(),
!canAccess("http", server.getHttpAddress())));
Contributor
Author
There was a problem hiding this comment.
Suggested assert seems incorrect coz if http is enabled than client should succeed in binding to http port.
We do assert if http is enabled, server should bind to http port and client should be able to connect to it. in L105
Contributor
There was a problem hiding this comment.
Thanks for the clarification. Then in line 113-114, we are trying to validate that if https is not enabled, you can't use http scheme to access an https address?
xiaoyuyao
reviewed
Mar 12, 2019
xiaoyuyao
reviewed
Mar 12, 2019
Contributor
xiaoyuyao
left a comment
xiaoyuyao
left a comment
There was a problem hiding this comment.
LGTM overall. Just have one minor question inline.
|
💔 -1 overall
This message was automatically generated. |
…tainerManagerHttpServer. Contributed by Ajay Kumar.
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
+1 for the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tainerManagerHttpServer. Contributed by Ajay Kumar.