HDFS-17115. HttpFS Add Support getErasureCodeCodecs API #5875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
slfan1989
reviewed
Jul 23, 2023
| WebHdfsFileSystem webHdfsFileSystem = (WebHdfsFileSystem) httpFs; | ||
| diffErasureCodingCodecs = webHdfsFileSystem.getAllErasureCodingCodecs(); | ||
| } else { | ||
| Assert.fail(fs.getClass().getSimpleName() + |
There was a problem hiding this comment.
use LambdaTestUtils.intercept
There was a problem hiding this comment.
Thanks for your suggestion, I'll make the required code changes promptly
slfan1989
reviewed
Jul 23, 2023
|
|
||
| for (Map.Entry<String, String> entry : dfsAllErasureCodingCodecs.entrySet()) { | ||
| Assert.assertTrue(diffErasureCodingCodecs.containsKey(entry.getKey())); | ||
| Assert.assertEquals(entry.getValue(), diffErasureCodingCodecs.get(entry.getKey())); |
slfan1989
reviewed
Jul 23, 2023
| Assert.assertEquals(entry.getValue(), diffErasureCodingCodecs.get(entry.getKey())); | ||
| } | ||
| } else { | ||
| Assert.fail(fs.getClass().getSimpleName() + " is not of type DistributedFileSystem."); |
There was a problem hiding this comment.
use LambdaTestUtils.intercept
slfan1989
approved these changes
Jul 23, 2023
slfan1989
approved these changes
Jul 25, 2023
|
🎊 +1 overall
This message was automatically generated. |
jiajunmao
pushed a commit
to jiajunmao/hadoop-MLEC
that referenced
this pull request
Feb 6, 2024
…. Contributed by Hualong Zhang. Reviewed-by: Shilun Fan <[email protected]> Signed-off-by: Ayush Saxena <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: HDFS-17115. Support getECPolices API in WebHDFS