Skip to content

Conversation

Hexiaoqiao
Copy link
Contributor

Description of PR

Add .vscode to gitignore.

How was this patch tested?

No.

For code changes:

  • [Y] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • [N] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • [N] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • [N] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 13m 7s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚 shadedclient 32m 33s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 blanks 0m 1s The patch has no blanks issues.
+1 💚 shadedclient 20m 25s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 46s The patch does not generate ASF License warnings.
70m 20s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5756/1/artifact/out/Dockerfile
GITHUB PR #5756
Optional Tests dupname asflicense codespell detsecrets
uname Linux 6b4f713ff47f 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 1a5340c
Max. process+thread count 558 (vs. ulimit of 5500)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5756/1/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@Hexiaoqiao Hexiaoqiao merged commit ba08f26 into apache:trunk Jun 18, 2023
@Hexiaoqiao
Copy link
Contributor Author

Committed to trunk. Thanks @ayushtkn for reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants