Skip to content

Conversation

@GuoPhilipse
Copy link
Member

@GuoPhilipse GuoPhilipse commented Nov 16, 2022

JIRA:HADOOP-18532
Fixt typos and update usage in FileSystemShell.md

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 55s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+0 🆗 markdownlint 0m 1s markdownlint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚 mvninstall 39m 35s trunk passed
+1 💚 mvnsite 1m 34s trunk passed
+1 💚 shadedclient 61m 17s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 1m 0s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 1m 18s the patch passed
+1 💚 shadedclient 21m 15s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 52s The patch does not generate ASF License warnings.
87m 17s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5141/1/artifact/out/Dockerfile
GITHUB PR #5141
Optional Tests dupname asflicense mvnsite codespell detsecrets markdownlint
uname Linux 2fb0fd4899cb 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / b45cef9
Max. process+thread count 558 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5141/1/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@slfan1989
Copy link
Contributor

@GuoPhilipse Thank you for your contribution, LGTM.
Can we include the Jira number in the title of the pr?

Copy link
Contributor

@hotcodemacha hotcodemacha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @GuoPhilipse for your contribution. Please file a JIRA and update the PR with it.

@GuoPhilipse
Copy link
Member Author

thanks @slfan1989 @ashutoshcipher for your review, seems i cannot open issues.apache.org ,will fire a JIRA once logged

@GuoPhilipse GuoPhilipse changed the title Fixt typos in FileSystemShell.md HADOOP-18532. Fixt typos in FileSystemShell.md Nov 17, 2022
@GuoPhilipse GuoPhilipse changed the title HADOOP-18532. Fixt typos in FileSystemShell.md HADOOP-18532 . Fix typos in FileSystemShell.md Nov 18, 2022
@GuoPhilipse GuoPhilipse changed the title HADOOP-18532 . Fix typos in FileSystemShell.md HADOOP-18532. Fix typos in FileSystemShell.md Nov 18, 2022
@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 0s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 markdownlint 0m 0s markdownlint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚 mvninstall 38m 58s trunk passed
+1 💚 mvnsite 1m 33s trunk passed
+1 💚 shadedclient 60m 23s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 1m 6s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 1m 24s the patch passed
+1 💚 shadedclient 21m 8s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 45s The patch does not generate ASF License warnings.
85m 56s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5141/2/artifact/out/Dockerfile
GITHUB PR #5141
Optional Tests dupname asflicense mvnsite codespell detsecrets markdownlint
uname Linux 2a8d399fa36d 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 3b80fed
Max. process+thread count 756 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5141/2/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@GuoPhilipse GuoPhilipse changed the title HADOOP-18532. Fix typos in FileSystemShell.md HADOOP-18532. Update command usage in FileSystemShell.md Nov 19, 2022
Copy link
Member

@aajisaka aajisaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, +1

@aajisaka aajisaka merged commit 069bd97 into apache:trunk Nov 21, 2022
@aajisaka
Copy link
Member

Thank you @GuoPhilipse for your contribution and thank you @slfan1989 @ashutoshcipher for your reviews!

HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants