HADOOP-18505. Handled ArrayIndexOutOfBoundsException in TestCoderBase #5065
+29
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
steveloughran
requested changes
Oct 23, 2022
| if (inputs.length != decoder.getNumParityUnits() + | ||
| decoder.getNumDataUnits()) { | ||
| throw new IllegalArgumentException("Invalid inputs length"); | ||
| throw new HadoopIllegalArgumentException("Invalid inputs length"); |
There was a problem hiding this comment.
implicit changes in public api; revert
There was a problem hiding this comment.
Thanks @steveloughran for the review. I have reverted the change.
| toEraseChunks[idx ++] = dataChunks[erasedDataIndexes[i]]; | ||
| dataChunks[erasedDataIndexes[i]] = null; | ||
| } else { | ||
| throw new HadoopIllegalArgumentException( |
There was a problem hiding this comment.
@steveloughran, sorry I don't quite understand this. Is this also a public API? I found that this is only being used in Test classes.
I have changed the exception type to IllegalArgumentException.
|
|
||
| // decode | ||
| backupAndEraseChunks(clonedDataChunks, parityChunks); | ||
| try { |
There was a problem hiding this comment.
use LambdaTestUtils.intercept() for all bits of test code which validates expected exceptions
There was a problem hiding this comment.
The backupAndEraseChunks method would only throw exception if the erased data index is out of bound. This is only true for the newly added value set.
Adding LambdaTestUtils.intercept() fails the tests for other parameterized values since LambdaTestUtils.intercept() @throws AssertionError if the evaluation call didn't raise an exception.
...op-common/src/test/java/org/apache/hadoop/io/erasurecode/rawcoder/TestDecodingValidator.java
Show resolved
Hide resolved
|
🎊 +1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
JIRA: HADOOP-18505
How was this patch tested?
Added a new value set and consequently modified the existing unit tests
testValidateandtestValidateWithBadDecodingof test classTestDecodingValidatorto verify the code change.For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?