YARN-11342. [Federation] Refactor getNewApplication, submitApplication Use FederationActionRetry. #5005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pplication Use FederationActionRetry.
slfan1989
changed the title
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
@goiri Can you help review this pr? Thank you very much! |
goiri
approved these changes
Oct 13, 2022
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
slfan1989
changed the title
slfan1989
changed the title
goiri
reviewed
Oct 18, 2022
|
|
||
| <property> | ||
| <name>yarn.router.submit.interval.time</name> | ||
| <value>10</value> |
There was a problem hiding this comment.
I will modify the configuration file.
| |`yarn.router.admin.address` | `0.0.0.0:8052` | Admin address at the router. | | ||
| |`yarn.router.webapp.https.address` | `0.0.0.0:8091` | Secure webapp address at the router. | | ||
| |`yarn.router.submit.retry` | `3` | The number of retries in the router before we give up. | | ||
| |`yarn.router.submit.interval.time` | `10` | The interval between two retry, the default value is 10ms. | |
There was a problem hiding this comment.
Thanks for your suggestion, I will modify the code.
| .runWithRetries(cleanUpRetryCountNum, cleanUpRetrySleepTime); | ||
| return ((FederationActionRetry<Boolean>) (retry) -> | ||
| invokeCleanUpFinishApp(appId, isQuery, request)) | ||
| .runWithRetries(cleanUpRetryCountNum, cleanUpRetrySleepTime); |
|
🎊 +1 overall
This message was automatically generated. |
goiri
approved these changes
Oct 19, 2022
| * cluster is composed of only 1 bad SubCluster. | ||
| */ | ||
| @Test | ||
| public void testGetNewApplicationOneBadSC() |
There was a problem hiding this comment.
Thanks for your suggestion, I will fix it.
|
🎊 +1 overall
This message was automatically generated. |
|
@goiri Thank you very much for helping to review the code! |
4 tasks
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
…n Use FederationActionRetry. (apache#5005)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: YARN-11342. [Federation] Refactor FederationClientInterceptor#submitApplication Use FederationActionRetry.
In this pr, the code for getNewApplication and submitApplication is refactored, and FederationActionRetry is used.
The code readability has been enhanced, and the specific execution logic is encapsulated in two methods,
invokeGetNewApplicationandinvokeSubmitApplication, which are both idempotent methods.Optimized the logic of SubmitRetries. When the number of retries defined by the user is greater than the number of surviving SubClusters in the cluster, we need to choose a smaller value between the two.
Part of the audit log logic optimization, we will record all failed retries in the audit log to facilitate troubleshooting.