HADOOP-18481. Don't warn on EnvironmentCredentialsProvider. #4973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
@steveloughran could you please review? I'll then pick up testing for #4698 (prerequisites for upgrading to V2) against |
Contributor
steveloughran
left a comment
steveloughran
left a comment
There was a problem hiding this comment.
code looks good, just wondering if we may want to do the same for a couple more providers which we can easily migrate
| for (Class<?> aClass : awsClasses) { | ||
|
|
||
| if (aClass.getName().contains(AWS_AUTH_CLASS_PREFIX)) { | ||
| if (!aClass.getSimpleName().equals("EnvironmentVariableCredentialsProvider") |
Contributor
There was a problem hiding this comment.
how about having an array of simple names to skip on, with that, EC2ContainerCredentialsProviderWrapper, and InstanceProfileCredentialsProvider in. we only added our own IAMInstanceCredentialsProvider with delegation tokens, HADOOP-15449, and until then just included the aws sdk one directly. any refs to either can be mapped to IAMInstanceCredentialsProvider before trying to instantiate
Contributor
Author
|
thanks @steveloughran, have added |
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
and you tested it against an s3 store again, right? |
Contributor
Author
|
Yes, sorry should have mentioned! Tested by setting |
Contributor
|
merged to trunk; will backport |
asfgit
pushed a commit
that referenced
this pull request
Oct 14, 2022
…tial Providers. (#4973) The AWS SDKV2 upgrade log no longer warns about instantiation of the v1 SDK credential providers which are commonly used in s3a configurations: * com.amazonaws.auth.EnvironmentVariableCredentialsProvider * com.amazonaws.auth.EC2ContainerCredentialsProviderWrapper * com.amazonaws.auth.InstanceProfileCredentialsProvider When the hadoop-aws module moves to the v2 SDK, references to these credential providers will be rewritten to their v2 equivalents. Follow-on to HADOOP-18382. "Upgrade AWS SDK to V2 - Prerequisites" Contributed by Ahmar Suhail
asfgit
pushed a commit
that referenced
this pull request
Oct 14, 2022
…tial Providers. (#4973) The AWS SDKV2 upgrade log no longer warns about instantiation of the v1 SDK credential providers which are commonly used in s3a configurations: * com.amazonaws.auth.EnvironmentVariableCredentialsProvider * com.amazonaws.auth.EC2ContainerCredentialsProviderWrapper * com.amazonaws.auth.InstanceProfileCredentialsProvider When the hadoop-aws module moves to the v2 SDK, references to these credential providers will be rewritten to their v2 equivalents. Follow-on to HADOOP-18382. "Upgrade AWS SDK to V2 - Prerequisites" Contributed by Ahmar Suhail
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
…tial Providers. (apache#4973) The AWS SDKV2 upgrade log no longer warns about instantiation of the v1 SDK credential providers which are commonly used in s3a configurations: * com.amazonaws.auth.EnvironmentVariableCredentialsProvider * com.amazonaws.auth.EC2ContainerCredentialsProviderWrapper * com.amazonaws.auth.InstanceProfileCredentialsProvider When the hadoop-aws module moves to the v2 SDK, references to these credential providers will be rewritten to their v2 equivalents. Follow-on to HADOOP-18382. "Upgrade AWS SDK to V2 - Prerequisites" Contributed by Ahmar Suhail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
JIRA
This PR prevents logging of V1 Credential provider warning for
EnvironmentCredentialsProvider.How was this patch tested?
Ran an integration test, checked what's logged. No warning logged for
EnvironmentCredentialsProvider, warning logged when I set cred provider ascom.amazonaws.auth.InstanceProfileCredentialsProvider