Skip to content

HDFS-16430. Validate maximum blocks in EC group when adding an EC policy #3899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2022
Merged

HDFS-16430. Validate maximum blocks in EC group when adding an EC policy #3899

merged 1 commit into from
Jan 24, 2022

Conversation

@cndaimin
Copy link
Contributor

@cndaimin cndaimin commented Jan 18, 2022

HDFS EC adopts the last 4 bits of block ID to store the block index in EC block group. Therefore maximum blocks in EC block group is 2^4=16, and which is defined here: HdfsServerConstants#MAX_BLOCKS_IN_GROUP.

Currently there is no limitation or warning when adding a bad EC policy with numDataUnits + numParityUnits > 16. It only results in read/write error on EC file with bad EC policy. To users this is not very straightforward.

@hadoop-yetus
Copy link

hadoop-yetus commented Jan 18, 2022

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 36s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 32m 32s trunk passed
+1 💚 compile 1m 25s trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚 compile 1m 18s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 checkstyle 1m 1s trunk passed
+1 💚 mvnsite 1m 26s trunk passed
+1 💚 javadoc 1m 3s trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 1m 35s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 spotbugs 3m 15s trunk passed
+1 💚 shadedclient 23m 21s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 1m 16s the patch passed
+1 💚 compile 1m 20s the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚 javac 1m 20s the patch passed
+1 💚 compile 1m 14s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 javac 1m 14s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 52s the patch passed
+1 💚 mvnsite 1m 20s the patch passed
+1 💚 javadoc 0m 53s the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 1m 23s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 spotbugs 3m 18s the patch passed
+1 💚 shadedclient 22m 17s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 225m 8s hadoop-hdfs in the patch passed.
+1 💚 asflicense 0m 47s The patch does not generate ASF License warnings.
324m 51s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3899/1/artifact/out/Dockerfile
GITHUB PR #3899
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname Linux 8de9f2ccad41 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 300f4d3
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3899/1/testReport/
Max. process+thread count 3359 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3899/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

ayushtkn
ayushtkn approved these changes Jan 19, 2022
View reviewed changes
Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cndaimin
Copy link
Contributor Author

cndaimin commented Jan 20, 2022

Thanks for your review! @ayushtkn

@ayushtkn ayushtkn merged commit 5ef335d into apache:trunk Jan 24, 2022
@ayushtkn
Copy link
Member

ayushtkn commented Jan 24, 2022

Thanx @cndaimin for the contribution and @tomscut for the review!!!

asfgit pushed a commit that referenced this pull request Jan 25, 2022
@cndaimin @jojochuang
HDFS-16430. Add validation to maximum blocks in EC group when adding …
728ed10 
…an EC policy (#3899). Contributed by daimin.

Reviewed-by: tomscut <[email protected]>
Signed-off-by: Ayush Saxena <[email protected]>
(cherry picked from commit 5ef335d)

 Conflicts:
	hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ErasureCodingPolicyManager.java
asfgit pushed a commit that referenced this pull request Jan 25, 2022
@cndaimin @jojochuang
HDFS-16430. Add validation to maximum blocks in EC group when adding …
0f0ebf9 
…an EC policy (#3899). Contributed by daimin.

Reviewed-by: tomscut <[email protected]>
Signed-off-by: Ayush Saxena <[email protected]>
(cherry picked from commit 5ef335d)

 Conflicts:
	hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ErasureCodingPolicyManager.java

(cherry picked from commit 728ed10)
bogthe pushed a commit to bogthe/hadoop that referenced this pull request Feb 2, 2022
@cndaimin
HDFS-16430. Add validation to maximum blocks in EC group when adding …
2e235a7 
…an EC policy (apache#3899). Contributed by daimin.

Reviewed-by: tomscut <[email protected]>
Signed-off-by: Ayush Saxena <[email protected]>
(cherry picked from commit 5ef335d)

 Conflicts:
	hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ErasureCodingPolicyManager.java
HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022
@cndaimin
HDFS-16430. Add validation to maximum blocks in EC group when adding …
973191e 
…an EC policy (apache#3899). Contributed by daimin.

Reviewed-by: tomscut <[email protected]>
Signed-off-by: Ayush Saxena <[email protected]>
jojochuang pushed a commit to jojochuang/hadoop that referenced this pull request May 23, 2023
@cndaimin @arp7
CDPD-40022. HDFS-16430. Add validation to maximum blocks in EC group …
7fc6ba0 
…when adding an EC policy (apache#3899). Contributed by daimin.

Reviewed-by: tomscut <[email protected]>
Signed-off-by: Ayush Saxena <[email protected]>
(cherry picked from commit 5ef335d)

 Conflicts:
	hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ErasureCodingPolicyManager.java

(cherry picked from commit 728ed10)

 Conflicts:
	hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ErasureCodingPolicyManager.java

Change-Id: Id779f8e3a16350d9793f079087ae30278b13483a
LiuGuH pushed a commit to LiuGuH/hadoop that referenced this pull request Mar 26, 2024
@cndaimin
HDFS-16430. Add validation to maximum blocks in EC group when adding …
4187424 
…an EC policy (apache#3899). Contributed by daimin.

Reviewed-by: tomscut <[email protected]>
Signed-off-by: Ayush Saxena <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ayushtkn ayushtkn ayushtkn approved these changes

@tomscut tomscut tomscut approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cndaimin @hadoop-yetus @ayushtkn @tomscut