HDFS-16220.[FGL]Configurable INodeMap#NAMESPACE_KEY_DEPTH&NUM_RANGES_STATIC. #3417
+206
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
jianghuazhu
force-pushed
the
HDFS-16220
branch
from
6b98ab9 to
0501b87
Compare
|
💔 -1 overall
This message was automatically generated. |
jianghuazhu
force-pushed
the
HDFS-16220
branch
from
0501b87 to
ba8541f
Compare
|
💔 -1 overall
This message was automatically generated. |
xinglin
approved these changes
Sep 14, 2021
Contributor
xinglin
left a comment
xinglin
left a comment
There was a problem hiding this comment.
Looking good overall. Thanks for working on this!
Contributor
There was a problem hiding this comment.
This is definitely one way to do it but is there a way we can make numSpaceKeyDepth/numRangesStatic a non-static variable?
numspaceKeyDepth -> numSpaceKeyDepth
numRangesStatic -> numRanges
Contributor
Author
There was a problem hiding this comment.
Thanks @xinglin for the comment.
I will update it later.
Contributor
There was a problem hiding this comment.
Also, if we want to support namespaceKeyDepth other than 2, we probably need to modify the range Keys we insert when we create new partitions. Instead of inserting range key such as [0, 16385], [1, 16385], [2, 16385], I think we might need to insert range keys as [0,0, 16385], [1,0,16385], [2,0,16385] ... for depth of 3 and [0,0,0,16385], [1,0,0,16385], [2,0,0,16385]... for depth of 4.
for (int p = 0; p < numRangesStatic; p++) {
INodeDirectory key = new INodeDirectory(INodeId.ROOT_INODE_ID,
"range key".getBytes(StandardCharsets.UTF_8), perm, 0);
key.setParent(new INodeDirectory((long)p, null, perm, 0));
Contributor
Author
There was a problem hiding this comment.
Thanks @xinglin for the comment.
I agree with you and I will update it later.
jianghuazhu
force-pushed
the
HDFS-16220
branch
4 times, most recently
from
8dae87f to
76553d1
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
jianghuazhu
force-pushed
the
HDFS-16220
branch
from
76553d1 to
728ef52
Compare
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
@xinglin, can you help review? Here are some phenomena in the debugging process. When numSpaceKeyDepth=4, numRanges=10 |
xinglin
approved these changes
Sep 19, 2021
Contributor
There was a problem hiding this comment.
Can we add a check here to make sure numRanges is power of 2? thanks,
Contributor
Author
There was a problem hiding this comment.
Thanks @xinglin for the comment.
I will update it later.
jianghuazhu
force-pushed
the
HDFS-16220
branch
from
728ef52 to
40d3186
Compare
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
@shvachko Could you please review this PR. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
INodeMap#NAMESPACE_KEY_DEPTH&NUM_RANGES_STATIC is configurable.
How was this patch tested?
INodeMap#NAMESPACE_KEY_DEPTH and NUM_RANGES_STATIC can be successfully obtained after changing the values of INodeMap#NAMESPACE_KEY_DEPTH and NUM_RANGES_STATIC in the Configuration.
jira:HDFS-16220