MAPREDUCE-7310. Clear the fileMap in JHEventHandlerForSigtermTest #2499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzx404243
changed the title
|
🎊 +1 overall
This message was automatically generated. |
jiwq
reviewed
Dec 3, 2020
Member
jiwq
left a comment
jiwq
left a comment
There was a problem hiding this comment.
+1 Thanks @lzx404243 for the contribution.
Contributor
Author
|
@jiwq Thanks for the review! Is there anything I can do on my end for this to be merged? |
Member
|
@aajisaka Can u help to review it? |
aajisaka
approved these changes
Jan 12, 2021
Member
|
Merged. Thank you @lzx404243 and @jiwq |
aajisaka
pushed a commit
that referenced
this pull request
Jan 12, 2021
) Co-authored-by: Zhengxi Li <[email protected]> Reviewed-by: Wanqiang Ji <[email protected]> Signed-off-by: Akira Ajisaka <[email protected]> (cherry picked from commit ca7dd5f)
aajisaka
pushed a commit
that referenced
this pull request
Jan 12, 2021
) Co-authored-by: Zhengxi Li <[email protected]> Reviewed-by: Wanqiang Ji <[email protected]> Signed-off-by: Akira Ajisaka <[email protected]> (cherry picked from commit ca7dd5f)
aajisaka
pushed a commit
that referenced
this pull request
Jan 12, 2021
) Co-authored-by: Zhengxi Li <[email protected]> Reviewed-by: Wanqiang Ji <[email protected]> Signed-off-by: Akira Ajisaka <[email protected]> (cherry picked from commit ca7dd5f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test
org.apache.hadoop.mapreduce.jobhistory.TestJobHistoryEventHandler.testSigTermedFunctionalityis not idempotent and fails if run twice in the same JVM, because it pollutes state shared among tests. It may be good to clean this state pollution so that some other tests do not fail in the future due to the shared state polluted by this test.Details
Running
TestJobHistoryEventHandler.testSigTermedFunctionalitytwice would result in the second run failing due toNullPointerExceptionshown in the following:The root cause of this is that running
TestJobHistoryEventHandler.testSigTermedFunctionalityresults in some entries to be added to the staticJobHistoryEventHandler.fileMap. The entries in thefileMapare not cleaned up when the test is done, resulting in aNullPointerExceptionin the second run as the stale object(added in the first run) in thefileMapis accessed.The fix is to clear the
fileMapat the end of the constructor ofJHEventHandlerForSigtermTest. Note that this has already been done in theJHEvenHandlerForTest, which is used by the other tests in theTestJobHistoryEventHandler. The same clean up needs to take place inJHEventHandlerForSigtermTest.With the proposed fix, the test does not pollute the shared state (and passes when run twice in the same JVM).
Link to JIRA issue: MAPREDUCE-7310