Skip to content

Conversation

@steveloughran
Copy link
Contributor

Contributed by Steve Loughran.

Because this looks like a JVM error string issue, changed to a slightly less brittle assert which should work across versions with different formatting.

…tion validation.

Contributed by Steve Loughran.

Change-Id: I0c8f069d264bf8586fea6015c39e5ca3267aed52
@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 6s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 0m 0s test4tests The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 34m 42s trunk passed
+1 💚 compile 21m 22s trunk passed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1
+1 💚 compile 17m 46s trunk passed with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10
+1 💚 checkstyle 0m 49s trunk passed
+1 💚 mvnsite 1m 32s trunk passed
+1 💚 shadedclient 17m 44s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 1m 1s trunk passed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1
+1 💚 javadoc 1m 33s trunk passed with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10
+0 🆗 spotbugs 2m 18s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 2m 15s trunk passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 54s the patch passed
+1 💚 compile 19m 21s the patch passed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1
+1 💚 javac 19m 21s the patch passed
+1 💚 compile 17m 6s the patch passed with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10
+1 💚 javac 17m 6s the patch passed
+1 💚 checkstyle 0m 51s the patch passed
+1 💚 mvnsite 1m 28s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 14m 57s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 1m 1s the patch passed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1
+1 💚 javadoc 1m 33s the patch passed with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10
+1 💚 findbugs 2m 23s the patch passed
_ Other Tests _
+1 💚 unit 10m 17s hadoop-common in the patch passed.
+1 💚 asflicense 0m 54s The patch does not generate ASF License warnings.
173m 15s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2427/1/artifact/out/Dockerfile
GITHUB PR #2427
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 4336adb21dbd 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 0461a07
Default Java Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2427/1/testReport/
Max. process+thread count 2534 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2427/1/console
versions git=2.17.1 maven=3.6.0 findbugs=4.1.3
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@steveloughran
Copy link
Contributor Author

Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A general observation, in case of open-jdk there is a space, but in case of oracle jdk there isn't.
Tried in both, the test passes.
+1

@ayushtkn ayushtkn merged commit ae7b00a into apache:trunk Nov 7, 2020
@ayushtkn
Copy link
Member

ayushtkn commented Nov 7, 2020

Thanx @steveloughran for the contribution

@steveloughran
Copy link
Contributor Author

can't have test failing.
This test case has been around for a long-long-time...we are going to have to backport to many places, aren't we?

asfgit pushed a commit that referenced this pull request Nov 7, 2020
…tion validation. (#2427). Contributed by Steve Loughran.
asfgit pushed a commit that referenced this pull request Nov 7, 2020
…tion validation. (#2427). Contributed by Steve Loughran.
asfgit pushed a commit that referenced this pull request Nov 7, 2020
…tion validation. (#2427). Contributed by Steve Loughran.
asfgit pushed a commit that referenced this pull request Nov 7, 2020
…tion validation. (#2427). Contributed by Steve Loughran.
asfgit pushed a commit that referenced this pull request Nov 28, 2020
…tion validation. (#2427). Contributed by Steve Loughran.
@steveloughran steveloughran deleted the BUG/HADOOP-17340-TestLdapMapping branch October 15, 2021 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants