Skip to content

Conversation

@aajisaka
Copy link
Member

@aajisaka aajisaka commented Oct 9, 2020

JIRA: https://issues.apache.org/jira/browse/HADOOP-17269

Manually tested with Java 11.0.7

$ mvn install -DskipTests -DskipShade
$ mvn findbugs:findbugs -pl hadoop-common-project/hadoop-common
(snip)
[INFO] Fork Value is true
     [java] SLF4J: No SLF4J providers were found.
     [java] SLF4J: Defaulting to no-operation (NOP) logger implementation
     [java] SLF4J: See http://www.slf4j.org/codes.html#noProviders for further details.
[INFO] Done FindBugs Analysis....

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 25s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 31m 28s trunk passed
+1 💚 compile 0m 16s trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 compile 0m 15s trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚 mvnsite 0m 20s trunk passed
+1 💚 shadedclient 48m 12s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 21s trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javadoc 0m 17s trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
_ Patch Compile Tests _
+1 💚 mvninstall 0m 11s the patch passed
+1 💚 compile 0m 12s the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javac 0m 12s the patch passed
+1 💚 compile 0m 11s the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚 javac 0m 10s the patch passed
+1 💚 mvnsite 0m 13s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 2s The patch has no ill-formed XML file.
+1 💚 shadedclient 15m 43s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 15s the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javadoc 0m 13s the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
_ Other Tests _
+1 💚 unit 0m 13s hadoop-project in the patch passed.
+1 💚 asflicense 0m 29s The patch does not generate ASF License warnings.
69m 34s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2374/1/artifact/out/Dockerfile
GITHUB PR #2374
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml
uname Linux 73ae0fa9451e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / deb35a3
Default Java Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2374/1/testReport/
Max. process+thread count 308 (vs. ulimit of 5500)
modules C: hadoop-project U: hadoop-project
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2374/1/console
versions git=2.17.1 maven=3.6.0
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@aajisaka aajisaka requested review from iwasakims and tasanuma October 9, 2020 09:02
Copy link
Member

@iwasakims iwasakims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. worked for OpenJDK 8 too on my local.

@aajisaka aajisaka merged commit 2de7240 into apache:trunk Oct 9, 2020
@aajisaka aajisaka deleted the HADOOP-17269 branch October 9, 2020 15:28
@aajisaka
Copy link
Member Author

aajisaka commented Oct 9, 2020

Merged. Thank you @iwasakims

@aajisaka
Copy link
Member Author

I'll revert this shortly because spotbugs 4.1.0 and upper have a license problem. spotbugs/spotbugs#1279

aajisaka added a commit that referenced this pull request Nov 12, 2020
aajisaka added a commit that referenced this pull request Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants