-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HADOOP-17261. s3a rename() needs s3:deleteObjectVersion permission #2303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-17261. s3a rename() needs s3:deleteObjectVersion permission #2303
Conversation
Stop using the versionId when building the list of files to delete as the rename progresses Change-Id: I2dcb3d9c7b1a6a40d05800135ce087d42294589f
Test verified to fail without the patch in the right env (version + S3guard + bulk). Docs cover failures during rename Change-Id: I0a2ce331df4b2728c6e0542cd62d5cb7fc6bc39b
mukund-thakur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Removed the version argument from the signatures of the methods, which ensures it can never creep back in without major work. Change-Id: Ie8f7f2677d82140246a41ac8dc96b69ea8dbb90e
|
testing in progress: S3 london |
|
Test with - https://issues.apache.org/jira/browse/HADOOP-17263 : read() didn't get as much back as expected (unrelated) That -Dscale option kicks off some MR jobs which spawn extra processes beyond the maven JUnit runners, the system may be overloading. Surprised how it surfaces though. I can see it amplifies a race condition in a non-atomic ++ call (more chance of pre-emption, longer delay for rescheduling), but read() not receiving enough data |
|
@bgaborg - could you look @ this when you have a chance? |
|
LGTM, +1 |
bgaborg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, +1
|
thank you :) |
…pache#2303) Contributed by Steve Loughran.
…2303) Contributed by Steve Loughran. Change-Id: I8e89a402a24bd9fb958e0fa93d1a28191093851d
…ermission (apache#2303) Contributed by Steve Loughran. Change-Id: Ia29d9d87e592799ed68da4a5d9912660db2ac934
Stop using the versionId when building the list of files
to delete as the rename progresses
Testing: manual. For anyone wishing to replicate the problem on an unpatched release
if that works, try renaming back.