-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HADOOP-17159 Ability for forceful relogin in UserGroupInformation class #2197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@liuml07 @steveloughran Please review |
|
💔 -1 overall
This message was automatically generated. |
|
LGTM, though I'll leave to someone who understands UGI to give the final vote |
|
Thanks @steveloughran I added Arpit and kihwal as reviewers. |
|
@arp7 @kihwal @xiaoyuyao Can you please review and provide your feedback ? |
|
The patch looks good to me overall. A question is: should we rename the word "force" with "ignoreTimeElapsed" to make it clear. If agreed on it includes updating the parameters name and Javadoc. Thoughts? @sguggilam I will give a final review next week. |
|
Yes @liuml07 that makes sense, let me update the PR |
liuml07
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
I will commit by the end of this week if no more comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Fore you mean Force?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes my bad, it's a typo, fixed it
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
…ss (#2197) Contributed by Sandeep Guggilam. Signed-off-by: Mingliang Liu <[email protected]> Signed-off-by: Steve Loughran <[email protected]>
…ss (#2197) Contributed by Sandeep Guggilam. Signed-off-by: Mingliang Liu <[email protected]> Signed-off-by: Steve Loughran <[email protected]>
…ss (#2197) Contributed by Sandeep Guggilam. Signed-off-by: Mingliang Liu <[email protected]> Signed-off-by: Steve Loughran <[email protected]>
|
@sguggilam When I backport the code, I went through the code again. I think I found one bug. Before I revert the change, I want to confirm with you. The existing calls of So, first we can change the new public API from to something like: Second, we should replace existing calls Could you explain more? Thanks! |
|
@liuml07 Yes that's right. How about just adding the existing method reloginFromKeytab(boolean checkTGT) which would just call reloginFromKeytab(checkTGT,false). This way it retains all existing calls. Any new calls who want to force relogin irrespective of anything can just call reloginFromKeytab(ignoreTimeElapsed) which would also set checkTGT to false as the user want to force re-login anyways Thoughts ? |
Since the forceful login is the main target, how about we create a new method name, and use
|
Yeah, the second parameter actually is Thanks! |
|
Yes @liuml07 I noticed that but found your code snippet to be right and felt it was a typo. Thanks, will send out a new PR |
The commit was reverted and a new PR for this JIRA is posted as #2249