HDFS-15393: Review of PendingReconstructionBlocks #2055
+90
−117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
goiri
reviewed
Jun 9, 2020
| synchronized (timedOutItems) { | ||
| return timedOutCount + timedOutItems.size(); | ||
| } | ||
| return timedOutCount + timedOutItems.size(); |
Member
There was a problem hiding this comment.
Unlikely but this can still be technically be inconsistent, right?
| while (iterator.hasNext()) { | ||
| DatanodeStorageInfo next = iterator.next(); | ||
| if (next.getDatanodeDescriptor() == dn.getDatanodeDescriptor()) { | ||
| if (next.getDatanodeDescriptor().equals(dn.getDatanodeDescriptor())) { |
Member
There was a problem hiding this comment.
This looks pretty bad... could this have had a negative impact in the past?
| fsRunning = false; | ||
| if(timerThread == null) return; | ||
| if (timerThread == null) | ||
| return; |
| * to exit. | ||
| */ | ||
| void stop() { | ||
| fsRunning = false; |
Member
There was a problem hiding this comment.
I can of like this. You think catching the interrupt is enough?
| * Iterate through all items and print them. | ||
| */ | ||
| void metaSave(PrintWriter out) { | ||
| synchronized (pendingReconstructions) { |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.