-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HDFS-15371 Nonstandard characters exist in NameNode.java #2031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
💔 -1 overall
This message was automatically generated. |
| DFS_NAMENODE_KERBEROS_PRINCIPAL_KEY, | ||
| DFS_NAMENODE_KERBEROS_INTERNAL_SPNEGO_PRINCIPAL_KEY, | ||
| DFS_HA_FENCE_METHODS_KEY, | ||
| DFS_HA_ZKFC_PORT_KEY, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the issue with having a comma at the end of an array?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does anything break because of this comma?
I personally don't see a point on removing this.
If we add a new key, it will reduce churn.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@goiri It is not break anything, I think the issue opener means the redundant comma is not formal java grammar.
|
I found that you submitted the source code 7 times, which is a non-standard way to submit. |
|
@jianghuazhu Thanks for your suggestion! I created a new pr: @goiri FYI Close this pr, the new one #2032 created |
NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute