Skip to content

Conversation

@zhaoyim
Copy link
Contributor

@zhaoyim zhaoyim commented May 22, 2020

NOTICE

Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 31s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 19m 17s trunk passed
+1 💚 compile 1m 8s trunk passed
+1 💚 checkstyle 0m 49s trunk passed
+1 💚 mvnsite 1m 13s trunk passed
+1 💚 shadedclient 16m 4s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 47s trunk passed
+0 🆗 spotbugs 2m 51s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 2m 48s trunk passed
-0 ⚠️ patch 3m 8s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+1 💚 mvninstall 1m 5s the patch passed
+1 💚 compile 0m 58s the patch passed
+1 💚 javac 0m 58s the patch passed
-0 ⚠️ checkstyle 0m 42s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 90 unchanged - 1 fixed = 91 total (was 91)
+1 💚 mvnsite 1m 5s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 14m 9s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 43s the patch passed
+1 💚 findbugs 2m 52s the patch passed
_ Other Tests _
-1 ❌ unit 100m 1s hadoop-hdfs in the patch passed.
+1 💚 asflicense 0m 41s The patch does not generate ASF License warnings.
166m 16s
Reason Tests
Failed junit tests hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes
hadoop.hdfs.server.namenode.TestDecommissioningStatusWithBackoffMonitor
hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
hadoop.hdfs.web.TestWebHDFS
hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics
hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
hadoop.hdfs.tools.TestDFSAdminWithHA
hadoop.hdfs.server.balancer.TestBalancerWithNodeGroup
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2031/1/artifact/out/Dockerfile
GITHUB PR #2031
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 96042d6512fe 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 9685314
Default Java Private Build-1.8.0_252-8u252-b09-1~18.04-b09
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-2031/1/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-2031/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-2031/1/testReport/
Max. process+thread count 4112 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-2031/1/console
versions git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

DFS_NAMENODE_KERBEROS_PRINCIPAL_KEY,
DFS_NAMENODE_KERBEROS_INTERNAL_SPNEGO_PRINCIPAL_KEY,
DFS_HA_FENCE_METHODS_KEY,
DFS_HA_ZKFC_PORT_KEY,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the issue with having a comma at the end of an array?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@goiri The issue HDFS-9929 forget to delete the comma.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does anything break because of this comma?
I personally don't see a point on removing this.
If we add a new key, it will reduce churn.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@goiri It is not break anything, I think the issue opener means the redundant comma is not formal java grammar.

@jianghuazhu
Copy link
Contributor

I found that you submitted the source code 7 times, which is a non-standard way to submit.

@zhaoyim
Copy link
Contributor Author

zhaoyim commented May 25, 2020

@jianghuazhu Thanks for your suggestion! I created a new pr:

@goiri FYI

Close this pr, the new one #2032 created

@zhaoyim zhaoyim closed this May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants