HADOOP-16925 MetricsConfig incorrectly loads the configuration whose value is String list in the properties file

[liujiayi771]

No description provided.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1 💚	mvninstall	19m 27s	trunk passed
+1 💚	compile	17m 52s	trunk passed
+1 💚	checkstyle	0m 51s	trunk passed
+1 💚	mvnsite	1m 29s	trunk passed
+1 💚	shadedclient	18m 33s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	1m 6s	trunk passed
+0 🆗	spotbugs	2m 17s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	2m 14s	trunk passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 54s	the patch passed
+1 💚	compile	16m 47s	the patch passed
+1 💚	javac	16m 47s	the patch passed
+1 💚	checkstyle	0m 51s	the patch passed
+1 💚	mvnsite	1m 23s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	14m 46s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	1m 3s	the patch passed
+1 💚	findbugs	2m 13s	the patch passed
		_ Other Tests _
+1 💚	unit	9m 12s	hadoop-common in the patch passed.
+1 💚	asflicense	0m 54s	The patch does not generate ASF License warnings.
		111m 20s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1896/1/artifact/out/Dockerfile
GITHUB PR	#1896
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 9ce4459edad0 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / ea68863
Default Java	1.8.0_242
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1896/1/testReport/
Max. process+thread count	1554 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1896/1/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 9s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1 💚	mvninstall	18m 59s	trunk passed
+1 💚	compile	19m 31s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	compile	16m 49s	trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	checkstyle	0m 47s	trunk passed
+1 💚	mvnsite	1m 26s	trunk passed
+1 💚	shadedclient	16m 31s	branch has no errors when building and testing our client artifacts.
-1 ❌	javadoc	0m 46s	hadoop-common in trunk failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
+1 💚	javadoc	0m 57s	trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+0 🆗	spotbugs	2m 16s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	2m 13s	trunk passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 49s	the patch passed
+1 💚	compile	20m 4s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javac	20m 4s	the patch passed
+1 💚	compile	17m 21s	the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	javac	17m 21s	the patch passed
+1 💚	checkstyle	0m 51s	the patch passed
+1 💚	mvnsite	1m 26s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	14m 10s	patch has no errors when building and testing our client artifacts.
-1 ❌	javadoc	0m 45s	hadoop-common in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
+1 💚	javadoc	1m 4s	the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	findbugs	2m 20s	the patch passed
		_ Other Tests _
+1 💚	unit	9m 23s	hadoop-common in the patch passed.
+1 💚	asflicense	0m 54s	The patch does not generate ASF License warnings.
		150m 36s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1896/3/artifact/out/Dockerfile
GITHUB PR	#1896
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 34e59b38ab1d 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / e756fe3
Default Java	Private Build-1.8.0_252-8u252-b09-1~18.04-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09
javadoc	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1896/3/artifact/out/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
javadoc	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1896/3/artifact/out/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1896/3/testReport/
Max. process+thread count	2291 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1896/3/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Neilxzn]

I found the same issue. Is there any progress about this patch ?

[steveloughran]

Is it possible to test this? That gives us the ability to detect any future regressions

[liujiayi771]

Is it possible to test this? That gives us the ability to detect any future regressions

I tried to add a unit test.

[hadoop-yetus]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 36s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+1 💚	mvninstall	30m 16s	trunk passed
+1 💚	compile	21m 37s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	compile	17m 42s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	checkstyle	0m 48s	trunk passed
+1 💚	mvnsite	1m 28s	trunk passed
+1 💚	shadedclient	16m 6s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 32s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	1m 31s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+0 🆗	spotbugs	2m 22s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	2m 18s	trunk passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 52s	the patch passed
+1 💚	compile	20m 6s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javac	20m 5s	the patch passed
+1 💚	compile	19m 34s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	javac	19m 34s	the patch passed
-0 ⚠️	checkstyle	0m 54s	hadoop-common-project/hadoop-common: The patch generated 1 new + 10 unchanged - 0 fixed = 11 total (was 10)
+1 💚	mvnsite	1m 35s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	16m 35s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 34s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	1m 42s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	findbugs	2m 47s	the patch passed
		_ Other Tests _
+1 💚	unit	10m 11s	hadoop-common in the patch passed.
+1 💚	asflicense	0m 53s	The patch does not generate ASF License warnings.
		171m 1s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1896/6/artifact/out/Dockerfile
GITHUB PR	#1896
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 900e3454ca9f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 86bbd38
Default Java	Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
checkstyle	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1896/6/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1896/6/testReport/
Max. process+thread count	1658 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1896/6/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

[steveloughran]

+1, merged to 3.2, 3.3 and trunk branches.

Thanks!