Skip to content

HADOOP-16825: Checkaccess testcase fix #1821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bilaharith wants to merge 6 commits into from
Closed

HADOOP-16825: Checkaccess testcase fix #1821

bilaharith wants to merge 6 commits into from

Conversation

@bilaharith
Copy link
Contributor

@bilaharith bilaharith commented Jan 28, 2020

NOTICE

Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute

@steveloughran
Copy link
Contributor

steveloughran commented Jan 31, 2020

thanks. Where did you test this, -and have you tried without the oauth settings?

@steveloughran steveloughran mentioned this pull request Jan 31, 2020
Closed
@steveloughran
Copy link
Contributor

steveloughran commented Jan 31, 2020

FWIW I've done a local test run in my configuration, but I need that test run info from @bilaharith too.

@bilaharith
Copy link
Contributor Author

bilaharith commented Feb 5, 2020

mvn -T 1C -Dparallel-tests=abfs -Dscale -DtestsThreadCount=2 clean verify

Driver test results using an account with namespace support in Central India:


[INFO] Tests run: 52, Failures: 0, Errors: 0, Skipped: 0
[WARNING] Tests run: 414, Failures: 0, Errors: 0, Skipped: 36
[WARNING] Tests run: 194, Failures: 0, Errors: 0, Skipped: 24

Driver test results using an account without namespace support in Central India:

[INFO] Tests run: 52, Failures: 0, Errors: 0, Skipped: 0
[WARNING] Tests run: 414, Failures: 0, Errors: 0, Skipped: 222
[WARNING] Tests run: 194, Failures: 0, Errors: 0, Skipped: 16

ThomasMarquardt
ThomasMarquardt reviewed Feb 5, 2020
View reviewed changes
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystem.java Outdated
public void access(final Path path, final FsAction mode) throws IOException {
LOG.debug("AzureBlobFileSystem.access path : {}, mode : {}", path, mode);
Path qualifiedPath = makeQualified(path);
Path qualifiedPath = path == null ? null : makeQualified(path);
Copy link
Contributor

@ThomasMarquardt ThomasMarquardt Feb 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original line 949 is correct. If path is null, FileSystem.access should throw IllegalArgumentException and that's what calling makeQualified(path) will do.

Copy link
Contributor Author

@bilaharith bilaharith Feb 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping it this way as we don't need to break the existing flow when the checkaccess flag is false.

Copy link
Contributor

@ThomasMarquardt ThomasMarquardt Feb 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t follow. What flow are you referring to? I think you should revert this line because null path should result in IllegalArgumentException. Calling makeQualified is a standard thing done by all the APIs taking a Path.

Copy link
Contributor Author

@bilaharith bilaharith Feb 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the addition as discussed.

ThomasMarquardt
ThomasMarquardt reviewed Feb 5, 2020
View reviewed changes
...p-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemCheckAccess.java Outdated

private FileSystem getTestUserFs() throws Exception {
private void setTestUserFs() throws Exception {
if(this.testUserFs != null) {
Copy link
Contributor

@ThomasMarquardt ThomasMarquardt Feb 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: please add a space between if and (.

Copy link
Contributor Author

@bilaharith bilaharith Feb 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

ThomasMarquardt
ThomasMarquardt reviewed Feb 5, 2020
View reviewed changes
...p-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemCheckAccess.java
this.testUserFs = fs;
}

@Test(expected = IllegalArgumentException.class)
Copy link
Contributor

@ThomasMarquardt ThomasMarquardt Feb 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is expected to throw IllegalArgumentException.

Copy link
Contributor Author

@bilaharith bilaharith Feb 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@hadoop-yetus
Copy link

hadoop-yetus commented Feb 6, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 2m 29s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 23m 35s trunk passed
+1 💚 compile 0m 28s trunk passed
+1 💚 checkstyle 0m 19s trunk passed
+1 💚 mvnsite 0m 30s trunk passed
+1 💚 shadedclient 14m 38s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 23s trunk passed
+0 🆗 spotbugs 0m 49s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 0m 48s trunk passed
-0 ⚠️ patch 1m 3s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 27s the patch passed
+1 💚 compile 0m 21s the patch passed
+1 💚 javac 0m 21s the patch passed
+1 💚 checkstyle 0m 14s the patch passed
+1 💚 mvnsite 0m 24s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 14m 56s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 19s the patch passed
+1 💚 findbugs 0m 53s the patch passed
_ Other Tests _
+1 💚 unit 1m 9s hadoop-azure in the patch passed.
+1 💚 asflicense 0m 28s The patch does not generate ASF License warnings.
64m 5s
Subsystem Report/Notes
Docker Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1821/4/artifact/out/Dockerfile
GITHUB PR #1821
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux f4c9f325b073 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 314e2f9
Default Java 1.8.0_242
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1821/4/testReport/
Max. process+thread count 341 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1821/4/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@apache apache deleted a comment from hadoop-yetus Feb 6, 2020
@apache apache deleted a comment from hadoop-yetus Feb 6, 2020
@apache apache deleted a comment from hadoop-yetus Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ThomasMarquardt ThomasMarquardt ThomasMarquardt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bilaharith @steveloughran @hadoop-yetus @ThomasMarquardt