-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HDFS-14638. [Dynamometer] Fix scripts to refer to current build structure. #1673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@smengcl would you like to review this? |
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
Thanks @jojochuang for pinging. Thanks @tasanuma for the patch. I tested this locally. Those scripts correctly points to the jars now: $ mvn install -Pdist -DskipTests -e -Dmaven.javadoc.skip=true
$ cd hadoop-dist/target/hadoop-3.3.0-SNAPSHOT
$ ./share/hadoop/tools/dynamometer/dynamometer-blockgen/bin/generate-block-lists.sh
Exception in thread "main" org.apache.commons.cli.MissingOptionException: Missing required options: fsimage_input_path, block_image_output_dir, num_datanodes
...
$ ./share/hadoop/tools/dynamometer/dynamometer-infra/bin/start-dynamometer-cluster.sh
2019-10-24 09:16:16,098 INFO dynamometer.Client: Initializing Client
2019-10-24 09:16:16,099 ERROR dynamometer.Client: Error running Client
org.apache.commons.cli.MissingOptionException: Missing required option: ...
$ ./share/hadoop/tools/dynamometer/dynamometer-workload/bin/start-workload.sh
Exception in thread "main" org.apache.commons.cli.MissingOptionException: Missing required options: nn_uri, mapper_class_name
...Before the patch is was complaining: $ ./share/hadoop/tools/dynamometer/dynamometer-blockgen/bin/generate-block-lists.sh
JAR does not exist or is not a normal file: /Users/smeng/repo/trunk/hadoop-dist/target/hadoop-3.3.0-SNAPSHOT/share/hadoop/tools/dynamometer/dynamometer-blockgen/lib/dynamometer-blockgen-*.jarLGTM +1 |
Contributor
|
+1 will merge the PR shortly. |
Member
Author
|
Thanks for reviewing and committing it, @smengcl and @jojochuang! |
amahussein
pushed a commit
to amahussein/hadoop
that referenced
this pull request
Oct 29, 2019
RogPodge
pushed a commit
to RogPodge/hadoop
that referenced
this pull request
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute