Skip to content

Conversation

@smengcl
Copy link
Contributor

@smengcl smengcl commented Jul 31, 2019

Modified existing unit test to verify the validity of the fix. Without the fix, the modified unit test WILL fail. Tested locally.

@sunchao sunchao added the HDFS label Jul 31, 2019
@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 138 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
0 mvndep 12 Maven dependency ordering for branch
+1 mvninstall 1221 trunk passed
+1 compile 207 trunk passed
+1 checkstyle 55 trunk passed
+1 mvnsite 86 trunk passed
+1 shadedclient 870 branch has no errors when building and testing our client artifacts.
+1 javadoc 53 trunk passed
0 spotbugs 43 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 179 trunk passed
_ Patch Compile Tests _
0 mvndep 12 Maven dependency ordering for patch
+1 mvninstall 73 the patch passed
+1 compile 215 the patch passed
+1 javac 215 the patch passed
+1 checkstyle 54 the patch passed
+1 mvnsite 84 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 807 patch has no errors when building and testing our client artifacts.
+1 javadoc 51 the patch passed
+1 findbugs 193 the patch passed
_ Other Tests _
+1 unit 118 hadoop-hdfs-client in the patch passed.
+1 unit 281 hadoop-hdfs-httpfs in the patch passed.
+1 asflicense 30 The patch does not generate ASF License warnings.
4786
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1192/1/artifact/out/Dockerfile
GITHUB PR #1192
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 23fe57df28d3 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / f86de6f
Default Java 1.8.0_222
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1192/1/testReport/
Max. process+thread count 609 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1192/1/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@jojochuang
Copy link
Contributor

LGTM

@jojochuang jojochuang merged commit 17e8cf5 into apache:trunk Aug 2, 2019
asfgit pushed a commit that referenced this pull request Oct 4, 2019
…turns null (#1192) Contributed by Siyao Meng.

(cherry picked from commit 17e8cf5)
asfgit pushed a commit that referenced this pull request Oct 4, 2019
…turns null (#1192) Contributed by Siyao Meng.

(cherry picked from commit 17e8cf5)
smengcl added a commit to smengcl/hadoop that referenced this pull request Oct 8, 2019
…y always returns null (apache#1192) Contributed by Siyao Meng.

(cherry picked from commit 17e8cf5)

Change-Id: Ied3f7ac9fc358ff45147b3f2d8d2379c937de3af
amahussein pushed a commit to amahussein/hadoop that referenced this pull request Oct 29, 2019
bentito pushed a commit to bentito/hadoop that referenced this pull request Dec 2, 2020
…turns null (apache#1192) Contributed by Siyao Meng.

(cherry picked from commit 17e8cf5)
bentito pushed a commit to bentito/hadoop that referenced this pull request Dec 3, 2020
…turns null (apache#1192) Contributed by Siyao Meng.

(cherry picked from commit 17e8cf5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants