Skip to content

Conversation

@ChenSammi
Copy link
Contributor

@ChenSammi ChenSammi requested a review from bshashikant July 26, 2019 03:29
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 44 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 mvninstall 575 trunk passed
+1 compile 363 trunk passed
+1 checkstyle 65 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 840 branch has no errors when building and testing our client artifacts.
+1 javadoc 155 trunk passed
0 spotbugs 424 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 618 trunk passed
_ Patch Compile Tests _
+1 mvninstall 554 the patch passed
+1 compile 355 the patch passed
+1 javac 355 the patch passed
+1 checkstyle 66 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 658 patch has no errors when building and testing our client artifacts.
+1 javadoc 160 the patch passed
+1 findbugs 622 the patch passed
_ Other Tests _
-1 unit 285 hadoop-hdds in the patch failed.
-1 unit 1794 hadoop-ozone in the patch failed.
+1 asflicense 43 The patch does not generate ASF License warnings.
7381
Reason Tests
Failed junit tests hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures
hadoop.ozone.om.TestScmSafeMode
hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
hadoop.ozone.client.rpc.TestOzoneRpcClient
hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1168/1/artifact/out/Dockerfile
GITHUB PR #1168
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 9b7fbe1ebdcb 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / ce99cc3
Default Java 1.8.0_212
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1168/1/artifact/out/patch-unit-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1168/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1168/1/testReport/
Max. process+thread count 4923 (vs. ulimit of 5500)
modules C: hadoop-ozone/integration-test U: hadoop-ozone/integration-test
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1168/1/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 102 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 mvninstall 685 trunk passed
+1 compile 427 trunk passed
+1 checkstyle 82 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 949 branch has no errors when building and testing our client artifacts.
+1 javadoc 177 trunk passed
0 spotbugs 465 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 675 trunk passed
_ Patch Compile Tests _
+1 mvninstall 589 the patch passed
+1 compile 380 the patch passed
+1 javac 380 the patch passed
+1 checkstyle 77 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 753 patch has no errors when building and testing our client artifacts.
+1 javadoc 172 the patch passed
+1 findbugs 674 the patch passed
_ Other Tests _
-1 unit 345 hadoop-hdds in the patch failed.
-1 unit 1978 hadoop-ozone in the patch failed.
+1 asflicense 42 The patch does not generate ASF License warnings.
8275
Reason Tests
Failed junit tests hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory
hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures
hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures
hadoop.ozone.om.TestScmSafeMode
hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
hadoop.ozone.client.rpc.TestOzoneRpcClient
hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1168/2/artifact/out/Dockerfile
GITHUB PR #1168
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux ec2c9d3ac9c8 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / aebac6d
Default Java 1.8.0_212
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1168/2/artifact/out/patch-unit-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1168/2/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1168/2/testReport/
Max. process+thread count 3943 (vs. ulimit of 5500)
modules C: hadoop-ozone/integration-test U: hadoop-ozone/integration-test
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1168/2/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@bshashikant
Copy link
Contributor

+1. LGTM.

@bshashikant bshashikant merged commit c01e137 into apache:trunk Jul 26, 2019
@bshashikant
Copy link
Contributor

Thanks @ChenSammi for working on this. I have committed this change to trunk.

shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
…apache#1168)

Fix java doc of table descriptor for default rate limiter and use double in the rate limit calculation
amahussein pushed a commit to amahussein/hadoop that referenced this pull request Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants