HDDS-1800. Result of author check is inverted

[adoroszlai]

What changes were proposed in this pull request?

Fix:

1. author check fails when no violations are found
2. author check violations are duplicated in the output

Eg. https://ci.anzix.net/job/ozone-nightly/173/consoleText says that:

The following tests are FAILED:

[author]: author check is failed (https://ci.anzix.net/job/ozone-nightly/173//artifact/build/author.out/*view*/)

but no actual @author tags were found:

$ curl -s 'https://ci.anzix.net/job/ozone-nightly/173//artifact/build/author.out/*view*/' | wc
       0       0       0

How was this patch tested?

$ bash -o pipefail -c 'hadoop-ozone/dev-support/checks/author.sh | tee build/author.out'; echo $?
0

$ wc build/author.out
       0       0       0 build/author.out

$ echo '// @author Tolkien' >> hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/BucketManager.java

$ bash -o pipefail -c 'hadoop-ozone/dev-support/checks/author.sh | tee build/author.out'; echo $?
./hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/BucketManager.java:// @author Tolkien
1

$ wc build/author.out
       1       3     108 build/author.out

[adoroszlai]

/label ozone

[adoroszlai]

@elek please review

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	39	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
0	shelldocs	1	Shelldocs was not available.
0	@author	0	Skipping @author checks as author.sh has been patched.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1	mvninstall	550	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	804	branch has no errors when building and testing our client artifacts.
		_ Patch Compile Tests _
+1	mvninstall	484	the patch passed
+1	mvnsite	0	the patch passed
+1	shellcheck	0	There were no new shellcheck issues.
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	682	patch has no errors when building and testing our client artifacts.
		_ Other Tests _
+1	unit	103	hadoop-hdds in the patch passed.
+1	unit	179	hadoop-ozone in the patch passed.
+1	asflicense	39	The patch does not generate ASF License warnings.
		3076

Subsystem	Report/Notes
Docker	Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1092/1/artifact/out/Dockerfile
GITHUB PR	#1092
Optional Tests	dupname asflicense mvnsite unit shellcheck shelldocs
uname	Linux d4fd95ae4ab3 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 18ee109
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1092/1/testReport/
Max. process+thread count	411 (vs. ulimit of 5500)
modules	C: hadoop-ozone U: hadoop-ozone
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1092/1/console
versions	git=2.7.4 maven=3.3.9 shellcheck=0.4.6
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[elek]

+1 thanks the fix @adoroszlai

But I would prefer to commit it under a separated issue number. I created https://issues.apache.org/jira/browse/HDDS-1800 to use.