feat: add neo4j and es connector #653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
yuluo-yx
commented
Nov 9, 2025
yuluo-yx
commented
- Fixed feat: support Neo4j connector #652
feat: add neo4j connector Signed-off-by: jishiwen.jsw <[email protected]>
yuluo-yx
force-pushed
the
neo4j-connector
branch
from
5ab5568 to
308469b
Compare
Signed-off-by: jishiwen.jsw <[email protected]>
Loognqiang
reviewed
Nov 14, 2025
...h/src/main/java/org/apache/geaflow/dsl/connector/elasticsearch/ElasticsearchTableSource.java
Outdated
Show resolved
Hide resolved
...h/src/main/java/org/apache/geaflow/dsl/connector/elasticsearch/ElasticsearchTableSource.java
Outdated
Show resolved
Hide resolved
...h/src/main/java/org/apache/geaflow/dsl/connector/elasticsearch/ElasticsearchTableSource.java
Outdated
Show resolved
Hide resolved
...h/src/main/java/org/apache/geaflow/dsl/connector/elasticsearch/ElasticsearchTableSource.java
Outdated
Show resolved
Hide resolved
...h/src/main/java/org/apache/geaflow/dsl/connector/elasticsearch/ElasticsearchTableSource.java
Outdated
Show resolved
Hide resolved
...h/src/main/java/org/apache/geaflow/dsl/connector/elasticsearch/ElasticsearchTableSource.java
Outdated
Show resolved
Hide resolved
...h/src/main/java/org/apache/geaflow/dsl/connector/elasticsearch/ElasticsearchTableSource.java
Outdated
Show resolved
Hide resolved
...h/src/main/java/org/apache/geaflow/dsl/connector/elasticsearch/ElasticsearchTableSource.java
Outdated
Show resolved
Hide resolved
...dsl-connector-neo4j/src/main/java/org/apache/geaflow/dsl/connector/neo4j/Neo4jTableSink.java
Outdated
Show resolved
Hide resolved
...dsl-connector-neo4j/src/main/java/org/apache/geaflow/dsl/connector/neo4j/Neo4jTableSink.java
Outdated
Show resolved
Hide resolved
2 tasks
Closed
Signed-off-by: jishiwen.jsw <[email protected]>
Signed-off-by: jishiwen.jsw <[email protected]>
...h/src/main/java/org/apache/geaflow/dsl/connector/elasticsearch/ElasticsearchTableSource.java
Show resolved
Hide resolved
...rch/src/main/java/org/apache/geaflow/dsl/connector/elasticsearch/ElasticsearchTableSink.java
Show resolved
Hide resolved
...dsl-connector-neo4j/src/main/java/org/apache/geaflow/dsl/connector/neo4j/Neo4jTableSink.java
Show resolved
Hide resolved
...dsl-connector-neo4j/src/main/java/org/apache/geaflow/dsl/connector/neo4j/Neo4jTableSink.java
Show resolved
Hide resolved
...l-connector-neo4j/src/main/java/org/apache/geaflow/dsl/connector/neo4j/Neo4jTableSource.java
Show resolved
Hide resolved
Contributor
|
Hi @yuluo-yx ，Thank you for your contribution. I left some comments. Also, please note that to ensure the basic usability of this feature, I suggest you add unit tests: For example, simulate an ES/Neo4j client (Mockito) to verify:
If you have time later, you could perhaps introduce integration tests based on testcontainer to verify that the connector runs stably. |
...rch/src/main/java/org/apache/geaflow/dsl/connector/elasticsearch/ElasticsearchTableSink.java
Show resolved
Hide resolved
Contributor
|
If you are currently busy with work, you can merge this PR first, and then start the relevant optimizations. |
...l-connector-neo4j/src/main/java/org/apache/geaflow/dsl/connector/neo4j/Neo4jTableSource.java
Outdated
Show resolved
Hide resolved
Signed-off-by: jishiwen.jsw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.