-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-13516][test] Bump MiniKdc to 3.2.0 to fix the failure of YARNSessionFIFOSecuredITCase on Java 11 #9622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 6b31336 (Wed Oct 16 08:34:21 UTC 2019) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
|
Have you verified that this works with all hadoop version we explicitly support? |
|
Yes. I have used Java 11 and the following hadoop versions to verify the
|
|
minikdc isn't just used by |
|
No, other modules using MiniKdc only were tested with the version 2.4.1 of Hadoop. Today I'll verify all. |
|
I used Java 11 and the Hadoop versions explicitly supported by Flink to verify that the following modules, which depend on MiniKdc, work well.
|
|
Could you rebase the PR and remove the |
…essionFIFOSecuredITCase on Java 11
a1b2919 to
6b31336
Compare
|
I updated the PR and Travis is successful. Thanks for reviewing @zentol. |
|
@zentol is on vacation. Can you help me merge this PR @tillrohrmann ? |
### What changes were proposed in this pull request? Hadoop jira: https://issues.apache.org/jira/browse/HADOOP-12911 In this jira, the author said to replace origin Apache Directory project which is not maintained (but not said it won't work well in jdk11) to Apache Kerby which is java binding(fit java version). And in Flink: apache/flink#9622 Author show the reason why hadoop-2.7.2's `MminiKdc` failed with jdk11. Because new encryption types of `es128-cts-hmac-sha256-128` and `aes256-cts-hmac-sha384-192` (for Kerberos 5) enabled by default were added in Java 11. Spark with `hadoop-2.7's MiniKdc`does not support these encryption types and does not work well when these encryption types are enabled, which results in the authentication failure. And when I test hadoop-2.7.2's minikdc in local, the kerberos 's debug error message is read message stream failed, message can't match. ### Why are the changes needed? Support jdk11 with hadoop-2.7 ### Does this PR introduce any user-facing change? NO ### How was this patch tested? Existed UT Closes #26594 from AngersZhuuuu/minikdc-3.2.0. Lead-authored-by: angerszhu <[email protected]> Co-authored-by: AngersZhuuuu <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
### What changes were proposed in this pull request? Hadoop jira: https://issues.apache.org/jira/browse/HADOOP-12911 In this jira, the author said to replace origin Apache Directory project which is not maintained (but not said it won't work well in jdk11) to Apache Kerby which is java binding(fit java version). And in Flink: apache/flink#9622 Author show the reason why hadoop-2.7.2's `MminiKdc` failed with jdk11. Because new encryption types of `es128-cts-hmac-sha256-128` and `aes256-cts-hmac-sha384-192` (for Kerberos 5) enabled by default were added in Java 11. Spark with `hadoop-2.7's MiniKdc`does not support these encryption types and does not work well when these encryption types are enabled, which results in the authentication failure. And when I test hadoop-2.7.2's minikdc in local, the kerberos 's debug error message is read message stream failed, message can't match. ### Why are the changes needed? Support jdk11 with hadoop-2.7 ### Does this PR introduce any user-facing change? NO ### How was this patch tested? Existed UT Closes apache#26594 from AngersZhuuuu/minikdc-3.2.0. Lead-authored-by: angerszhu <[email protected]> Co-authored-by: AngersZhuuuu <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
What is the purpose of the change
This pull request bumps
MiniKdcto 3.2.0 to fix the failure ofYARNSessionFIFOSecuredITCaseon Java 11.The failure of
YARNSessionFIFOSecuredITCaseis due to the failure of authentication when the yarn client requests access authorization of resource manager, and subsequent retries lead to test timeout. New encryption types ofes128-cts-hmac-sha256-128andaes256-cts-hmac-sha384-192(for Kerberos 5) enabled by default were added in Java 11, while the current version ofMiniKdcused by Flink does not support these encryption types and does not work well when these encryption types are enabled, which results in the authentication failure.Brief change log
Verifying this change
This change is already covered by existing tests, such as
YARNSessionFIFOSecuredITCase.Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation