FALCON-2300, Backlog Metrics Workflow Failure Fix #384
Conversation
|
I will be pasting the results of dev testing soon. |
PracheerAgarwal-zz
changed the title
PracheerAgarwal-zz
changed the title
PracheerAgarwal-zz
changed the title
|
Added two process with sla as 5 minutes. mysql> select * from PENDING_INSTANCES; than deleted entry for process3-2, to check if process3-1 will get picked for SLA alerts or not. It get picket, that means replacing break with continue works. mysql> select * from ENTITY_SLA_ALERTS; |
| + "instanceTime:{}", entity.getName(), clusterName, nominalTime, entityType); | ||
| AbstractWorkflowEngine wfEngine = WorkflowEngineFactory.getWorkflowEngine(); | ||
|
|
||
| if ((System.currentTimeMillis() - nominalTime.getTime())/(1000*60*60*24) >= Integer.parseInt( |
There was a problem hiding this comment.
Move this to the else part of if (instancesResult.getInstances().length > 0) .. Lets not eagerly assume the instance info is not available.
| AbstractWorkflowEngine wfEngine = WorkflowEngineFactory.getWorkflowEngine(); | ||
|
|
||
| if ((System.currentTimeMillis() - nominalTime.getTime())/(1000*60*60*24) >= Integer.parseInt( | ||
| RuntimeProperties.get().getProperty("worklflow.expiration.period", "7"))) { |
There was a problem hiding this comment.
Make the property name to a constant field. Also, the property name can be : workflow.history.expiration.period.days (more intuitive and also indicates the time unit)
3 participants
No description provided.