Refactor RemotingService and SyncFrom... interfaces
#146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@githublaohu Please fix CI errors.
Checkstyle guide: https://eventmesh.apache.org/zh/community/contribute/contribute/ |
|
@githublaohu Please merge my edition https://github.com/Pil0tXia/eventmesh-dashboard/tree/pil0txia/review_146. |
added 12 commits
June 6, 2024 09:55
Pil0tXia
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
Subsequent work of this PR:
- Merge edition https://github.com/Pil0tXia/eventmesh-dashboard/tree/pil0txia/review_146.
- Remove redundant empty comments, fix typos and translate Chinese comments.
Comment on lines
181
to
185
| /** | ||
| * 解除玩关系，才能删除 | ||
| * | ||
| * @param clusterEntityList | ||
| */ |
Pil0tXia
changed the title
SyncFrom... interfaces
This was referenced Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #issue_id
Motivation
Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.
Modifications
Describe the modifications you've done.
Documentation