This fixes some tests #607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that were not properly checking that the MemoryRequestServer (and the sketch) were closing intermediate increases in size when off-heap.
jmalkin
requested changes
Oct 6, 2024
Contributor
jmalkin
left a comment
jmalkin
left a comment
There was a problem hiding this comment.
Not sure where the extra slashes came from. Everything else is good.
src/test/java/org/apache/datasketches/hll/DirectAuxHashMapTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/apache/datasketches/hll/DirectAuxHashMapTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/apache/datasketches/hll/DirectAuxHashMapTest.java
Outdated
Show resolved
Hide resolved
jmalkin
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
that were not properly checking that the MemoryRequestServer (and the
sketch) were closing intermediate increases in size when off-heap.