Update contributor guide with updated scalar function howto #9438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comphead
reviewed
Mar 4, 2024
| - a new line in `create_physical_expr`/`create_physical_fun` mapping the built-in to the implementation | ||
| - tests to the function. | ||
| - Add the actual implementation of the function to a new module file within: | ||
| - [here](../../../datafusion/functions-array/src) for array functions |
comphead
reviewed
Mar 4, 2024
| - [here](../../../datafusion/functions/src/math) for math functions | ||
| - [here](../../../datafusion/functions/src/regex) for regex functions | ||
| - [here](../../../datafusion/functions/src/string) for string functions | ||
| - create a new module [here](../../../datafusion/functions/src) for other functions. New function modules should likely have their own feature flag. |
Contributor
There was a problem hiding this comment.
Suggested change
| - create a new module [here](../../../datafusion/functions/src) for other functions. New function modules should likely have their own feature flag. | |
| - create a new module [here](../../../datafusion/functions/src) for other functions. |
This is slightly unclear as for me... Or we probably need to find better statement
Contributor
Author
There was a problem hiding this comment.
Ah, very true, I'll see if I can come up with something. I was trying to say that any new 'area' under functions, say datafusion/functions/src/vectors should be guarded by a feature flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #9437
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?