Skip to content

Conversation

@Omega359
Copy link
Contributor

Which issue does this PR close?

Closes #13406

Rationale for this change

Completing support for utf8view in functions.

What changes are included in this PR?

Code, tests.

Are these changes tested?

Yes

Are there any user-facing changes?

No

@github-actions github-actions bot added sqllogictest SQL Logic Tests (.slt) functions Changes to functions implementation labels Nov 14, 2024
Copy link
Member

@timsaucer timsaucer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@Omega359 Omega359 marked this pull request as ready for review November 14, 2024 18:21
@alamb alamb merged commit 7e69580 into apache:main Nov 15, 2024
25 checks passed
@alamb
Copy link
Contributor

alamb commented Nov 15, 2024

🚀

@alamb
Copy link
Contributor

alamb commented Nov 15, 2024

I tried to write some more tests for this code and I think it may have introduced a bug. See

@Omega359
Copy link
Contributor Author

Omega359 commented Nov 15, 2024 via email

@Omega359 Omega359 deleted the feature/crypto_utf8view branch November 16, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

functions Changes to functions implementation sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for Utf8View to crypto functions

3 participants