Skip to content

Conversation

@Dandandan
Copy link
Contributor

Which issue does this PR close?

Rationale for this change

We can use Vec rather than the primitive builders, they are slightly more efficient and provide better syntax.

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the physical-expr Changes to the physical-expr crates label Aug 22, 2024
Copy link
Contributor

@jayzhan211 jayzhan211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Dandandan Dandandan merged commit 3de50c8 into apache:main Aug 23, 2024
@Dandandan
Copy link
Contributor Author

Thanks for the review @jayzhan211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

physical-expr Changes to the physical-expr crates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants