Skip to content

Conversation

@timsaucer
Copy link
Member

This is an alternate approach to #11550
After we discuss, I will update the PR description if necessary. See the other PR for context.

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

timsaucer-may and others added 6 commits July 18, 2024 16:27
…guments. Other parameters will be set via the ExprFuncBuilder
…g ExprFunctionExt trait so we can guarantee a consistent user experience no matter which they call on the Expr and which on the builder
@github-actions github-actions bot added documentation Improvements or additions to documentation sql SQL Planner logical-expr Logical plan and expressions optimizer Optimizer rules core Core DataFusion crate substrait Changes to the substrait crate labels Jul 21, 2024
@jayzhan211
Copy link
Contributor

I had tried to directly modify Expr before, but ends up builder API. I couldn't remember the reason

@timsaucer
Copy link
Member Author

Closing in favor of #11550

@timsaucer timsaucer closed this Jul 22, 2024
@timsaucer timsaucer deleted the feature/alternate-function-extension branch July 22, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate documentation Improvements or additions to documentation logical-expr Logical plan and expressions optimizer Optimizer rules sql SQL Planner substrait Changes to the substrait crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants