Skip to content

Maybe a misuse of plan_err #7879

@waynexia

Description

@waynexia

Describe the bug

https://github.com/apache/arrow-datafusion/blob/37d6bf08c948418fe6c72d072d988c2875d81e02/datafusion/physical-expr/src/sort_expr.rs#L64-L73

This function (PhysicalSortExpr::evaluate_to_sort_column()) is in the execution phase. Errors at this stage should be exec_err! rather than plan_err!, right?

I also see other places have similar behavior and open this ticket to confirm. I'll submit a patch to change them if so.

To Reproduce

No response

Expected behavior

No response

Additional context

No response

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions