Add support for string literal concatenation #2003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iffyio
reviewed
Aug 20, 2025
iffyio
changed the title
iffyio
changed the title
etgarperets
force-pushed
the
adjacent_string_literal_concatenation-support
branch
from
04c8f9b to
ecdee10
Compare
Contributor
Author
|
@iffyio All fixes are in and waiting on a review |
iffyio
reviewed
Sep 2, 2025
Contributor
iffyio
left a comment
iffyio
left a comment
There was a problem hiding this comment.
Thanks @etgarperets! Changes look good to me overall, left a minor comment
Co-authored-by: Ifeanyi Ubah <[email protected]>
iffyio
approved these changes
Sep 2, 2025
Contributor
iffyio
left a comment
iffyio
left a comment
There was a problem hiding this comment.
LGTM! Thanks @etgarperets!
cc @alamb
etgarperets
deleted the
adjacent_string_literal_concatenation-support
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… space in mySQL