Upgrade protobuf and remove GH Action googletest-installer #773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new version **should** remove the need for the blocked GH action. Ref: MaterializeInc/rust-protobuf-native#20 Ref: apache#763
Michael-J-Ward
force-pushed
the
upgrade-protobuf
branch
from
cc2e104 to
f380e9f
Compare
Member
|
Thank you for fixing this! |
timsaucer
approved these changes
Jul 25, 2024
andygrove
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #772.
Closes #763.
Rationale for this change
The
markusjx/googletest-installeraction is not allowed by our CI (see #772).And it should no longer be necessary since upstream rolled out a fix that makes the installer unnecessary.
What changes are included in this PR?
Upgrade deps, remove the action step.
Are there any user-facing changes?
No