fix: ensure document names with _local in them get properly url encoded #342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jumoel
commented
Apr 22, 2024
| req.uri += '/' + opts.path | ||
| } else if (opts.doc) { | ||
| if (!/^_design|_local/.test(opts.doc)) { | ||
| if (!/^(_design|_local)/.test(opts.doc)) { |
There was a problem hiding this comment.
Should we test for a slash immediately following _design or _local as well?
Suggested change
| if (!/^(_design|_local)/.test(opts.doc)) { | |
| if (!/^(_design|_local)\//.test(opts.doc)) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix a bug where a document whose name included
_localsomewhere would not get properly URL encoded.Non-replicating documents need to start with
_localand not just contain_local. The regular expression testing for this was missing a parenthesis.Testing recommendations
This will allow documents that have a name both containing characters that need to be URL encoded as well as
_localto be properly inserted.GitHub issue number
Related Pull Requests
Checklist