Allow case insensitive vm names while creating lb rules #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DaanHoogland Is it too late to pull this in for 4.18? |
Member
|
@kiwiflyer |
Got it, thanks! |
Member
|
LGTM @davidjumani what do we need to merge this? |
Contributor
Author
|
Just click the merge button :) |
Member
|
I meant to say, in terms of testing and review @davidjumani I'll merge this however as changes make sense to me and Build has passed. |
Contributor
Author
|
My bad @rohityadavcloud I had tested this myself and verified the fix |
hrak
pushed a commit
to hrak/cloudstack-kubernetes-provider
that referenced
this pull request
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In kubernetes, node names are in lower case but a VM can have an upper case name in cloudstack
This can cause issues mapping kuberenetes nodes to cloudstack VMs
Fixes this issue