-
Notifications
You must be signed in to change notification settings - Fork 884
JAVA-2813: Don't fail when secure bundle is specified together with other options #1476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 71a352f.
core/src/main/java/com/datastax/oss/driver/api/core/session/SessionBuilder.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastax/oss/driver/api/core/session/SessionBuilder.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastax/oss/driver/api/core/session/SessionBuilder.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastax/oss/driver/api/core/session/SessionBuilder.java
Outdated
Show resolved
Hide resolved
examples/src/main/java/com/datastax/oss/driver/examples/astra/AstraReadCassandraVersion.java
Show resolved
Hide resolved
integration-tests/src/test/java/com/datastax/oss/driver/api/core/cloud/CloudIT.java
Outdated
Show resolved
Hide resolved
integration-tests/src/test/java/com/datastax/oss/driver/api/core/cloud/CloudIT.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks good to me (pending the additional local DC check requested by Alexandre).
I'm not sure I agree with the change though: we decided to fail fast precisely because we didn't want to miss the fact that some options were going to be ignored. So it sounds consistent that tools would have to add logic to work around that.
The issue is with frameworks that provide some form of support for creating CqlSession instances in a more or less automated way. Take Spring Boot, for instance: the default (And it's not realistic to offer to add support to Astra directly in Spring Boot: Astra being proprietary and commercial, it's likely that such a contribution would meet some resistance to say the least.) |
core/src/main/java/com/datastax/oss/driver/api/core/session/SessionBuilder.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastax/oss/driver/api/core/session/SessionBuilder.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastax/oss/driver/api/core/session/SessionBuilder.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastax/oss/driver/api/core/session/SessionBuilder.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastax/oss/driver/api/core/session/SessionBuilder.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastax/oss/driver/api/core/session/SessionBuilder.java
Outdated
Show resolved
Hide resolved
…ssionBuilder.java Co-authored-by: Alexandre Dutra <[email protected]>
…ssionBuilder.java Co-authored-by: Alexandre Dutra <[email protected]>
…ssionBuilder.java Co-authored-by: Alexandre Dutra <[email protected]>
…e has local-datacenter defined
todo: