[CALCITE-1544] Fix AggregateJoinTransposeRule transform failure #344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "allColumnsInAggregate" variable is inferred by expanding the aggregate keys with equative join keys. It's not appropriate to let this flag to determine whether we should convert the query since the row type will easily be unmatched.
julianhyde
pushed a commit
to julianhyde/calcite
that referenced
this pull request
Jan 4, 2017
…(Kurt Young) The "allColumnsInAggregate" variable is inferred by expanding the aggregate keys with equative join keys. It's not appropriate to let this flag to determine whether we should convert the query since the row type will easily be unmatched. Close apache#344
ldming
pushed a commit
to ldming/mycalcite
that referenced
this pull request
Sep 13, 2018
…(Kurt Young) The "allColumnsInAggregate" variable is inferred by expanding the aggregate keys with equative join keys. It's not appropriate to let this flag to determine whether we should convert the query since the row type will easily be unmatched. Close apache/calcite#344
pfzhan
pushed a commit
to pfzhan/calcite
that referenced
this pull request
Jul 18, 2024
KE-11534 [Follow up]IF and IFNULL do not fold as constants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "allColumnsInAggregate" variable is inferred by expanding the aggregate keys with equative join keys. It's not appropriate to let this flag to determine whether we should convert the query since the row type will easily be unmatched.