-
Notifications
You must be signed in to change notification settings - Fork 239
[CALCITE-7165] Upgrade OWASP plugin version to 12.1.3 for JDKs > 8 #294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
settings.gradle.kts
Outdated
| idv("org.jetbrains.gradle.plugin.idea-ext") | ||
| idv("org.nosphere.apache.rat") | ||
| idv("org.owasp.dependencycheck") | ||
| if (JavaVersion.current().isJava8) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should also apply for 9 and 10.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I will take care of it.
|
Tested with Java 8, The OWASP plugin fails, but the build generally works, which is a good as we can get. |
|
I have pushed this by accident, but then force-pushed the previous state. |
|
@stoty What command are you using to check if OWASP plugin runs fine or not? I have tried the commands above and both fail with NPE on every JDK that I tested. |
|
I use
I've just tested it with this patch on JDK11 successfully.
|
|
It also worked yesterday but for the past few hours it consistently fails or hangs; quite strange. |
|
Maybe your cached DB is corrupted, try to delete and re-download it |
|
I removed the entire Could it be that it fails only when it is creating the DB from scratch? |
|
I have also deleted my DB, then run owasp with Java 11, and it worked fine. |
stoty
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM
|
Today the errors disappeared also for me. I run |
|
Yes, even with the key, downloading the DB takes ~5-10 minutes |
fa7ef02 to
7b202e8
Compare
|
Rebased, squashed, and amended commit message. I will merge this once CI runs. |
No description provided.