Migrate arrow and workspace to Rust 2024
#8578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
parquet
alamb
approved these changes
Oct 9, 2025
| /// | ||
| /// The pointer is assumed to have been obtained using CString::into_raw. | ||
| #[no_mangle] | ||
| #[unsafe(no_mangle)] |
There was a problem hiding this comment.
TIL why this is marked unsafe: https://doc.rust-lang.org/reference/abi.html#the-no_mangle-attribute
(I don't think the actual safety is affected, just that rustc got more pedantic)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This is the last part of #8227, reverting package editions back to use the workspace edition.
What changes are included in this PR?
Migrate
arrowto Rust 2024, update workspace edition and use workspace edition in workspace packages.Are these changes tested?
CI
Are there any user-facing changes?
Yes