[Avro] Preserve value metadata of map #8271
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
arrow
|
@yongkyunlee Thank you so much for getting this PR up! I just verified locally that #8220 resolves this by running your new test on my branch. Are we okay with getting that PR in first as well? |
|
@jecsand838 Ah okay! Yes sounds good. Once that PR is merged, I'll just create a new PR with the tests (including the ones from my previous closed PR) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This PR preserves the metadata that value contains when arrow-avro decoder flushes.
It is required to support value type
enumwhich stores the enum definition as a json string in the field metadata.What changes are included in this PR?
This PR fixes decoder flush logic to preserve the metadata of the
valueof map field.Are these changes tested?
Added a unit test
Are there any user-facing changes?
N/A