-
Notifications
You must be signed in to change notification settings - Fork 1k
Add RecordBatch::schema_metadata_mut and Field::metadata_mut
#7664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RecordBatch::metadata_mut and Field::metadata_mutRecordBatch::schema_metadata_mut and Field::metadata_mut
|
Failing integration test: apache/arrow-js#15 |
Seems is has passed now |
alamb
approved these changes
Jun 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Andrew Lamb <[email protected]>
|
Thanks @emilk |
|
This is a good candidate for adding to the next minor release btw |
8 tasks
This was referenced Jun 26, 2025
grtlr
pushed a commit
to rerun-io/rerun
that referenced
this pull request
Jun 27, 2025
### Related * Contains apache/arrow-rs#7664 ### What Full release log: https://github.com/apache/arrow-rs/releases/tag/55.2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
RecordBatch#7628Rationale for this change
Allows for fast and convenient mutating of the metadata of record batches and fields.
What changes are included in this PR?
Added:
RecordBatch::schema_metadata_mutField::metadata_mutWhy call it
schema_metadata_mutand not justmetadata_mut?See #7628 (comment) for motivation