Skip to content

Add BooleanArray::true_count and BooleanArray::false_count #2957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 28, 2022
Merged

Add BooleanArray::true_count and BooleanArray::false_count #2957

merged 2 commits into from
Oct 28, 2022

Conversation

@tustvold
Copy link
Contributor

@tustvold tustvold commented Oct 27, 2022 •
edited by alamb
Loading

Which issue does this PR close?

Closes #2963

Rationale for this change

apache/datafusion#3989 (comment)

What changes are included in this PR?

Are there any user-facing changes?

@tustvold tustvold mentioned this pull request Oct 27, 2022
Merged
@tustvold tustvold force-pushed the add-true-false-count branch from 1912d14 to 7dd649d Compare October 27, 2022 21:01
tustvold
tustvold commented Oct 27, 2022
View reviewed changes
@github-actions github-actions bot added the arrow Changes to the arrow crate label Oct 27, 2022
alamb
alamb reviewed Oct 28, 2022
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tustvold -- looks good to me

arrow-array/src/array/boolean_array.rs Outdated
&self.data.buffers()[0]
}

/// Returns the number of true values within this buffer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// Returns the number of true values within this buffer
/// Returns the number of non null, true values within this array

arrow-array/src/array/boolean_array.rs Outdated

/// Returns the number of false values within this buffer
pub fn false_count(&self) -> usize {
match self.data.null_buffer() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this could be simplified into self.size() - self.null_count() - self.true_count() ? I think that would be basically as fast?

@alamb
Copy link
Contributor

alamb commented Oct 28, 2022

I filed #2963 to track this

@tustvold tustvold merged commit 843a2e5 into apache:master Oct 28, 2022
@ursabot
Copy link

ursabot commented Oct 28, 2022

Benchmark runs are scheduled for baseline = 87ac05b and contender = 843a2e5. 843a2e5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alamb alamb alamb approved these changes

Assignees

No one assigned

Labels

arrow Changes to the arrow crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Optimized way to count the numbers of true and false values in a BooleanArray

3 participants

@tustvold @alamb @ursabot